Skip to content

Competative coding #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ankitakulkarnigit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Competative coding #1136

ankitakulkarnigit wants to merge 1 commit into from

Conversation

@ankitakulkarnigit
Copy link

@ankitakulkarnigit ankitakulkarnigit commented Oct 13, 2025

No description provided.

@super30admin
Copy link
Owner

super30admin commented Oct 13, 2025

  • Strengths:
    • The student has implemented a more efficient solution than the reference, demonstrating a good understanding of hashmap usage for reducing time complexity.
    • The code is clean, readable, and follows best practices.
    • The solution handles edge cases implicitly by the nature of the algorithm.
  • Areas for Improvement:
    • The comment at the top of the file mentions "Time Complexity =O(n)" and "Space Complexity = O(n)", but it is written in a Java-like comment style (//). In Python, comments should use #.
    • The README.md file contains the problem statement, which is good, but it should be clear whether this was provided by the student or was part of the problem setup. If it was added by the student, it shows good documentation practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankitakulkarnigit @super30admin